Conversation
jserv
reviewed
Apr 1, 2025
simplefs.h
Outdated
Comment on lines
150
to
153
| #elif SIMPLEFS_AT_LEAST(6, 8, 0) | ||
| struct bdev_handle | ||
| *s_journal_bdev_handle; /* v6.7+ external journal device */ | ||
| #endif |
Collaborator
There was a problem hiding this comment.
Can you check if the condition fits Linux v6.7 as well?
Collaborator
Author
There was a problem hiding this comment.
I believe this change was introduced in v6.7.
The commit:
d577c8aaed2035fb7bcc970058a9d8c46c26fcaa
ext4: Convert to bdev_open_by_dev()
modifies the ext4 filesystem by replacing struct block_device with struct bdev_handle.
(here is the patch lists: https://lore.kernel.org/all/20230818123232.2269-1-jack@suse.cz/#r)
And this commit is included in tag v6.7
$ git tag --contains d577c8aae
.....
v6.14-rc5
v6.14-rc6
v6.14-rc7
v6.7
v6.7-rc1
v6.7-rc2
v6.7-rc3
v6.7-rc4
.....
Collaborator
There was a problem hiding this comment.
Thus, refine the use of SIMPLEFS_AT_LEAST macro.
To align with the best practices recommended by Linux kernel v6.9 API. This commit adds struct file and other related functions to support v6.9. The sturct bdev_handle is still retained for compatibility with v6.7 ref: start to support struct file* https://patchwork.kernel.org/project/linux-block/patch/20240427211305.GG1495312@ZenIV/#25828002 https://lore.kernel.org/all/20240123-vfs-bdev-file-v2-0-adbd023e19cc@kernel.org/ Move struct bdev_handle private to the block layer https://lore.kernel.org/all/20240123-vfs-bdev-file-v2-29-adbd023e19cc@kernel.org/
RoyWFHuang
force-pushed
the
Feature/Upgrade_API
branch
from
1386ddc to
357a813
Compare
Collaborator
|
Thank @RoyWFHuang for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To align with the best practices recommended by Linux kernel v6.9 API. This commit adds struct file and other related functions to support v6.9. The sturct bdev_handle is still retained for compatibility with v6.7
ref:
https://patchwork.kernel.org/project/linux-block/patch/20240427211305.GG1495312@ZenIV/#25828002 https://lore.kernel.org/all/20240123-vfs-bdev-file-v2-0-adbd023e19cc@kernel.org/